Skip to content

Move ephemeral storage contents out of container resource page #52628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Move ephemeral storage contents out of container resource page #52628

wants to merge 1 commit into from
+309 −295

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Oct 5, 2025

This PR moves the ephemeral storage related configuration out of the container resource management page. This proposal is based on the following observations:

  • the current container resource management page is too long (1000+ lines) for maintenance.
  • the ephemeral storage section is well structured and self-contained.
  • the ephemeral storage section itself is 300+ lines, suitable for a dedicated page.
  • the configuration of ephemeral storage is a complicated topic in and by itself -- it involves operations for admins (i.e. one FS vs two FS) and for app developers (i.e. container level requests).
  • the management of local ephemeral storage is a pain point for many cluster operators. We may envision more details to be added to this topic.

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 5, 2025
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 5, 2025
@netlify Netlify
Copy link

netlify bot commented Oct 5, 2025 •
edited
Loading

✅ Pull request preview available for checking

Name Link
🔨 Latest commit b94586a
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/68e5b1db8e1f3600086f64b9
😎 Deploy Preview https://deploy-preview-52628--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@lmktfy
Copy link
Contributor

lmktfy commented Oct 5, 2025

/label refactor

@k8s-ci-robot k8s-ci-robot added the refactor Indicates a PR with large refactoring changes e.g. removes files or moves content label Oct 5, 2025
lmktfy
lmktfy previously requested changes Oct 5, 2025
View reviewed changes
Copy link
Contributor

@lmktfy lmktfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this.

I very strongly recommend moving the page about Local ephemeral storage to live within https://kubernetes.io/docs/concepts/storage/

@tengqm
Copy link
Contributor Author

tengqm commented Oct 5, 2025

Thanks for spotting this.

I very strongly recommend moving the page about Local ephemeral storage to live within https://kubernetes.io/docs/concepts/storage/

Makes sense. Revised.

@lmktfy lmktfy dismissed their stale review October 7, 2025 19:59

Superseded

lmktfy
lmktfy reviewed Oct 7, 2025
View reviewed changes
Copy link
Contributor

@lmktfy lmktfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

content/en/docs/concepts/storage/ephemeral-storage.md Outdated
Kubernetes lets you track, reserve and limit the amount
of ephemeral local storage a Pod can consume.

### Configurations for local ephemeral storage {#configurations}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Configurations for local ephemeral storage {#configurations}
## Configurations for local ephemeral storage {#configurations}

content/en/docs/concepts/storage/ephemeral-storage.md Outdated
sizeLimit: 500Mi
```
### How Pods with ephemeral-storage requests are scheduled
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### How Pods with ephemeral-storage requests are scheduled
## How Pods with ephemeral-storage requests are scheduled

content/en/docs/concepts/storage/ephemeral-storage.md Outdated
The scheduler ensures that the sum of the resource requests of the scheduled containers is less than the capacity of the node.
### Ephemeral storage consumption management {#resource-emphemeralstorage-consumption}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Ephemeral storage consumption management {#resource-emphemeralstorage-consumption}
## Ephemeral storage consumption management {#resource-emphemeralstorage-consumption}

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5e6ef033d135cd2494bb9185698fdf6b13bd80d1

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 8, 2025
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot requested a review from lmktfy October 8, 2025 00:32
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from lmktfy. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shannonxtreme shannonxtreme Awaiting requested review from shannonxtreme

@lmktfy lmktfy Awaiting requested review from lmktfy

Assignees

@lmktfy lmktfy

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language refactor Indicates a PR with large refactoring changes e.g. removes files or moves content size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tengqm @lmktfy @k8s-ci-robot